Bug 138301 - [EFL] Remove dependency of PageViewportController from PageViewportControllerClient
Summary: [EFL] Remove dependency of PageViewportController from PageViewportController...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-03 00:14 PST by Ryuan Choi
Modified: 2014-11-03 03:26 PST (History)
2 users (show)

See Also:

Attachments
Patch (12.08 KB, patch)
2014-11-03 00:20 PST, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2014-11-03 00:14:43 PST 
PageViewportControllerClient does not need to keep the instance of PageViewportController.
Comment 1 Ryuan Choi 2014-11-03 00:20:29 PST 
Created attachment 240832 [details]
Patch
Comment 2 Gyuyoung Kim 2014-11-03 00:29:34 PST 
Comment on attachment 240832 [details]
Patch

LGTM. PageViewportControllerClientEfl already had a member variable of EwkView which has a member variable of PageViewportController. r=me.

BTW, I don't think EwkView doesn't need to has m_pageViewportControllerClient as member variable. Because it is only needed by PageViewportController.
Comment 3 Ryuan Choi 2014-11-03 02:50:04 PST 
(In reply to comment #2)
> Comment on attachment 240832 [details]
> Patch
> 
> LGTM. PageViewportControllerClientEfl already had a member variable of
> EwkView which has a member variable of PageViewportController. r=me.
> 
> BTW, I don't think EwkView doesn't need to has
> m_pageViewportControllerClient as member variable. Because it is only needed
> by PageViewportController.

I think that PageViewportController takes the commond logic while PageViewportControllerClient takes port specific logic as callback style of PageViewportController.

Anyway, I also agree that PageViewportControllerClientEfl can be merged into EwkView as not a member but also a interface.

If you aree, I will make it in different bug.
Comment 4 WebKit Commit Bot 2014-11-03 03:26:45 PST 
Comment on attachment 240832 [details]
Patch

Clearing flags on attachment: 240832

Committed r175468: <http://trac.webkit.org/changeset/175468>
Comment 5 WebKit Commit Bot 2014-11-03 03:26:50 PST 
All reviewed patches have been landed.  Closing bug.