Created attachment 240831 [details] patch FindController::getFindIndicatorBitmapAndRect has a lot of overlap with WebCore FrameSnapshotting functions.
Not sure if the extra paint is acceptable, but I haven't quite worked out how to get rid of it without making FrameSnapshotting uglier.
Attachment 240831 [details] did not pass style-queue: ERROR: Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 240831 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=240831&action=review > Source/WebKit2/WebProcess/WebPage/FindController.cpp:264 > + auto snapshot = snapshotSelection(frame, WebCore::SnapshotOptionsForceBlackText); Don't like auto here.
<rdar://problem/18855863>
http://trac.webkit.org/changeset/175484