Bug 138300 - Use FrameSnapshotting functions in FindController::getFindIndicatorBitmap
Summary: Use FrameSnapshotting functions in FindController::getFindIndicatorBitmap
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2014-11-03 00:13 PST by Tim Horton
Modified: 2014-11-03 12:09 PST (History)
4 users (show)

See Also:

patch (9.50 KB, patch)
2014-11-03 00:13 PST, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-11-03 00:13:39 PST
Created attachment 240831 [details]

FindController::getFindIndicatorBitmapAndRect has a lot of overlap with WebCore FrameSnapshotting functions.
Comment 1 Tim Horton 2014-11-03 00:14:17 PST
Not sure if the extra paint is acceptable, but I haven't quite worked out how to get rid of it without making FrameSnapshotting uglier.
Comment 2 WebKit Commit Bot 2014-11-03 00:17:03 PST
Attachment 240831 [details] did not pass style-queue:

ERROR: Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
ERROR: Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 5 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2014-11-03 09:00:49 PST
Comment on attachment 240831 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=240831&action=review

> Source/WebKit2/WebProcess/WebPage/FindController.cpp:264
> +    auto snapshot = snapshotSelection(frame, WebCore::SnapshotOptionsForceBlackText);

Don't like auto here.
Comment 4 Radar WebKit Bug Importer 2014-11-03 11:45:54 PST
Comment 5 Tim Horton 2014-11-03 12:09:21 PST