Bug 138298 - [GTK] FTL JIT is not working (does not build and does not run)
Summary: [GTK] FTL JIT is not working (does not build and does not run)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-02 17:59 PST by Akos Kiss
Modified: 2014-11-02 23:53 PST (History)
8 users (show)

See Also:


Attachments
Proposed patch. (5.77 KB, patch)
2014-11-02 18:05 PST, Akos Kiss
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Akos Kiss 2014-11-02 17:59:56 PST
When trying to enable FTL JIT for GTK (by building with: Tools/Scripts/update-webkitgtk-libs && Tools/Scripts/update-webkitgtk-libs llvm && Tools/Scripts/build-jsc --gtk --ftl-jit), there are several failures.

First, when building, CMake complains about LIBCXXABI:

CMake Error at Source/cmake/OptionsGTK.cmake:317 (find_package):
  By not providing "FindLIBCXXABI.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "LIBCXXABI", but CMake did not find one.

If we overcome that, then LLVM bails out with some runtime errors, e.g.:
  
sunspider-1.0/string-validate-input.js.ftl-eager: jsc: RuntimeDyldELF.cpp:283: void llvm::RuntimeDyldELF::resolveX86_64Relocation(const llvm::SectionEntry &, uint64_t, uint64_t, uint32_t, int64_t, uint64_t): Assertion `RealOffset <= (2147483647) && RealOffset >= (-2147483647-1)' failed.
sunspider-1.0/string-validate-input.js.ftl-eager: Aborted (core dumped)
sunspider-1.0/string-validate-input.js.ftl-eager: ERROR: Unexpected exit code: 134
Comment 1 Akos Kiss 2014-11-02 18:05:05 PST
Created attachment 240825 [details]
Proposed patch.

No regressions with run-javascriptcore-tests on x86_64/Linux/GTK.
Comment 2 Carlos Garcia Campos 2014-11-02 23:15:43 PST
Comment on attachment 240825 [details]
Proposed patch.

Thanks!
Comment 3 WebKit Commit Bot 2014-11-02 23:53:12 PST
Comment on attachment 240825 [details]
Proposed patch.

Clearing flags on attachment: 240825

Committed r175465: <http://trac.webkit.org/changeset/175465>
Comment 4 WebKit Commit Bot 2014-11-02 23:53:17 PST
All reviewed patches have been landed.  Closing bug.