Bug 138289 - Reduce the cost of argumentCount checks in the JS bindings
Summary: Reduce the cost of argumentCount checks in the JS bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-01 23:27 PDT by Chris Dumez
Modified: 2014-11-02 10:19 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.72 KB, patch)
2014-11-01 23:30 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-11-01 23:27:17 PDT
Reduce the cost of argumentCount checks in the JS bindings by hinting to the compiler that it is UNLIKELY that those methods are called with too few arguments.
Comment 1 Chris Dumez 2014-11-01 23:30:00 PDT
Created attachment 240807 [details]
Patch
Comment 2 WebKit Commit Bot 2014-11-02 08:38:00 PST
Comment on attachment 240807 [details]
Patch

Clearing flags on attachment: 240807

Committed r175462: <http://trac.webkit.org/changeset/175462>
Comment 3 WebKit Commit Bot 2014-11-02 08:38:03 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Chris Dumez 2014-11-02 10:17:36 PST
(In reply to comment #4)
> This broke bindings tests:
> https://build.webkit.org/builders/
> Apple%20Mavericks%20Debug%20WK2%20%28Tests%29/builds/7751/steps/bindings-
> generation-tests/logs/stdio

Oh, they need to be rebaselined, I'll take care of it now, thanks.
Comment 6 Chris Dumez 2014-11-02 10:19:53 PST
Rebaselined the bindings tests in <http://trac.webkit.org/changeset/175463>.