Bug 138285 – Support modern range loops over CSSValueList

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Chris Dumez]

We should support modern range loops over CSSValueList and kill the custom CSSValueListInspector / CSSValueListIterator classes to modernize the code a bit.

[Chris Dumez]

Created attachment 240798 [details]
Patch

[WebKit Commit Bot]

Attachment 240798 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSToStyleMap.cpp:546:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/css/DeprecatedStyleBuilder.cpp:1571:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 240800 [details]
Patch

[WebKit Commit Bot]

Attachment 240800 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSToStyleMap.cpp:546:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/css/DeprecatedStyleBuilder.cpp:1571:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 240856 [details]
Patch

[WebKit Commit Bot]

Attachment 240856 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSToStyleMap.cpp:546:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/css/DeprecatedStyleBuilder.cpp:1530:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andreas Kling]

Comment on attachment 240856 [details]
Patch

r=me

[Chris Dumez]

Created attachment 240867 [details]
Patch

[WebKit Commit Bot]

Attachment 240867 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSToStyleMap.cpp:546:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/css/DeprecatedStyleBuilder.cpp:1530:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 240867 [details]
Patch

Clearing flags on attachment: 240867

Committed r175487: <http://trac.webkit.org/changeset/175487>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

Comment on attachment 240867 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240867&action=review

> Source/WebCore/css/StyleResolver.cpp:2037
> +    ASSERT(it != values.end());

arf. This should be it == values.end(), my bad. will fix now.

[Chris Dumez]

(In reply to comment #12)
> Comment on attachment 240867 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240867&action=review
> 
> > Source/WebCore/css/StyleResolver.cpp:2037
> > +    ASSERT(it != values.end());
> 
> arf. This should be it == values.end(), my bad. will fix now.

Landed assertion fix in <http://trac.webkit.org/changeset/175490>.