Bug 138273 – Simple line layout: Cleanup line initialization and line closing.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

This is in preparation to support multiple render elements.

[zalan]

The next step to abstract out text handling so that a text fragment can manage continuation (can transition from one render element to another)

[zalan]

Created attachment 240779 [details]
Patch

[Antti Koivisto]

Comment on attachment 240779 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240779&action=review

> Source/WebCore/rendering/SimpleLineLayout.cpp:313
> +        , committedLogicalRight(0)

Why is this one "logical"? If we are going to support vertical text should some others be logical too?

> Source/WebCore/rendering/SimpleLineLayout.cpp:314
> +        , currentPosition(0)

maybe just call it 'position'? Word "current" rarely adds much.

[zalan]

Created attachment 240803 [details]
Patch

[Build Bot]

Created attachment 240805 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[zalan]

(In reply to comment #3)
> Comment on attachment 240779 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240779&action=review
> 
> > Source/WebCore/rendering/SimpleLineLayout.cpp:313
> > +        , committedLogicalRight(0)
> 
> Why is this one "logical"? If we are going to support vertical text should
> some others be logical too?
Done.

> 
> > Source/WebCore/rendering/SimpleLineLayout.cpp:314
> > +        , currentPosition(0)
> 
> maybe just call it 'position'? Word "current" rarely adds much.
Done.

[Build Bot]

Created attachment 240808 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[zalan]

Created attachment 240929 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 240929 [details]
Patch

Clearing flags on attachment: 240929

Committed r175565: <http://trac.webkit.org/changeset/175565>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

(In reply to comment #9)
> Comment on attachment 240929 [details]
> Patch
> 
> Clearing flags on attachment: 240929
> 
> Committed r175565: <http://trac.webkit.org/changeset/175565>

It broke the Apple Windows build, as the EWS noticed:
     1>..\rendering\SimpleLineLayout.cpp(678): error C2512: 'WebCore::SimpleLineLayout::Run' : no appropriate default constructor available

[zalan]

(In reply to comment #11)
> (In reply to comment #9)
> > Comment on attachment 240929 [details]
> > Patch
> > 
> > Clearing flags on attachment: 240929
> > 
> > Committed r175565: <http://trac.webkit.org/changeset/175565>
> 
> It broke the Apple Windows build, as the EWS noticed:
>      1>..\rendering\SimpleLineLayout.cpp(678): error C2512:
> 'WebCore::SimpleLineLayout::Run' : no appropriate default constructor
> available
Thanks.
http://trac.webkit.org/changeset/175574