Bug 138273 - Simple line layout: Cleanup line initialization and line closing.
Summary: Simple line layout: Cleanup line initialization and line closing.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-31 20:07 PDT by zalan
Modified: 2014-11-04 12:53 PST (History)
9 users (show)

See Also:

Attachments
Patch (17.27 KB, patch)
2014-10-31 20:28 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (23.25 KB, patch)
2014-11-01 20:46 PDT, zalan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (1.30 MB, application/zip)
2014-11-01 22:01 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (1.31 MB, application/zip)
2014-11-02 00:22 PDT, Build Bot 		no flags Details
Patch (23.24 KB, patch)
2014-11-04 09:40 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-10-31 20:07:25 PDT 
This is in preparation to support multiple render elements.
Comment 1 zalan 2014-10-31 20:21:39 PDT 
The next step to abstract out text handling so that a text fragment can manage continuation (can transition from one render element to another)
Comment 2 zalan 2014-10-31 20:28:19 PDT 
Created attachment 240779 [details]
Patch
Comment 3 Antti Koivisto 2014-11-01 07:46:32 PDT 
Comment on attachment 240779 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240779&action=review

> Source/WebCore/rendering/SimpleLineLayout.cpp:313
> +        , committedLogicalRight(0)

Why is this one "logical"? If we are going to support vertical text should some others be logical too?

> Source/WebCore/rendering/SimpleLineLayout.cpp:314
> +        , currentPosition(0)

maybe just call it 'position'? Word "current" rarely adds much.
Comment 4 zalan 2014-11-01 20:46:23 PDT 
Created attachment 240803 [details]
Patch
Comment 5 Build Bot 2014-11-01 22:01:29 PDT 
Created attachment 240805 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 6 zalan 2014-11-01 22:24:28 PDT 
(In reply to comment #3)
> Comment on attachment 240779 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240779&action=review
> 
> > Source/WebCore/rendering/SimpleLineLayout.cpp:313
> > +        , committedLogicalRight(0)
> 
> Why is this one "logical"? If we are going to support vertical text should
> some others be logical too?
Done.

> 
> > Source/WebCore/rendering/SimpleLineLayout.cpp:314
> > +        , currentPosition(0)
> 
> maybe just call it 'position'? Word "current" rarely adds much.
Done.
Comment 7 Build Bot 2014-11-02 00:22:49 PDT 
Created attachment 240808 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 8 zalan 2014-11-04 09:40:01 PST 
Created attachment 240929 [details]
Patch
Comment 9 WebKit Commit Bot 2014-11-04 12:08:13 PST 
Comment on attachment 240929 [details]
Patch

Clearing flags on attachment: 240929

Committed r175565: <http://trac.webkit.org/changeset/175565>
Comment 10 WebKit Commit Bot 2014-11-04 12:08:18 PST 
All reviewed patches have been landed.  Closing bug.
Comment 11 Csaba Osztrogonác 2014-11-04 12:34:51 PST 
(In reply to comment #9)
> Comment on attachment 240929 [details]
> Patch
> 
> Clearing flags on attachment: 240929
> 
> Committed r175565: <http://trac.webkit.org/changeset/175565>

It broke the Apple Windows build, as the EWS noticed:
     1>..\rendering\SimpleLineLayout.cpp(678): error C2512: 'WebCore::SimpleLineLayout::Run' : no appropriate default constructor available
Comment 12 zalan 2014-11-04 12:53:51 PST 
(In reply to comment #11)
> (In reply to comment #9)
> > Comment on attachment 240929 [details]
> > Patch
> > 
> > Clearing flags on attachment: 240929
> > 
> > Committed r175565: <http://trac.webkit.org/changeset/175565>
> 
> It broke the Apple Windows build, as the EWS noticed:
>      1>..\rendering\SimpleLineLayout.cpp(678): error C2512:
> 'WebCore::SimpleLineLayout::Run' : no appropriate default constructor
> available
Thanks.
http://trac.webkit.org/changeset/175574