WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
138265
Whitespace cleanup in Screen.h
https://bugs.webkit.org/show_bug.cgi?id=138265
Summary
Whitespace cleanup in Screen.h
Simon Fraser (smfr)
Reported
2014-10-31 15:38:22 PDT
Whitespace cleanup in Screen.h
Attachments
Patch
(2.03 KB, patch)
2014-10-31 15:40 PDT
,
Simon Fraser (smfr)
cdumez
: review+
simon.fraser
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2014-10-31 15:40:08 PDT
Created
attachment 240763
[details]
Patch
Chris Dumez
Comment 2
2014-10-31 15:56:38 PDT
Comment on
attachment 240763
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=240763&action=review
> Source/WebCore/page/Screen.h:42 > +class Screen : public ScriptWrappable, public RefCounted<Screen>, public DOMWindowProperty {
nit: we could mark the class as final since we're at it.
> Source/WebCore/page/Screen.h:44 > + static PassRefPtr<Screen> create(Frame *frame) { return adoptRef(new Screen(frame)); }
nit: Could we fix the star placement as well?
Simon Fraser (smfr)
Comment 3
2014-10-31 16:21:56 PDT
https://trac.webkit.org/r175434
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug