Bug 138263 - Change the ScrollingThread code to use RunLoop::main().dispatch() rather than callOnMainThread(), which has Obj-C overhead
Summary: Change the ScrollingThread code to use RunLoop::main().dispatch() rather than...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-10-31 15:20 PDT by Simon Fraser (smfr)
Modified: 2014-10-31 16:14 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.27 KB, patch)
2014-10-31 15:21 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-10-31 15:20:23 PDT 
Change the ScrollingThread code to use RunLoop::main().dispatch() rather than callOnMainThread(), which has Obj-C overhead
Comment 1 Simon Fraser (smfr) 2014-10-31 15:21:34 PDT 
Created attachment 240759 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-10-31 15:22:09 PDT 
rdar://problem/18833601
Comment 3 Geoffrey Garen 2014-10-31 15:23:56 PDT 
Comment on attachment 240759 [details]
Patch

Should we change the implementation of callOnMainThread to use RunLoop::main().dispatch?
Comment 4 Simon Fraser (smfr) 2014-10-31 15:30:11 PDT 
(In reply to comment #3)
> Comment on attachment 240759 [details]
> Patch
> 
> Should we change the implementation of callOnMainThread to use
> RunLoop::main().dispatch?

Probably, but the fix needs to take the iOS WebThread into account.
Comment 5 WebKit Commit Bot 2014-10-31 16:14:47 PDT 
Comment on attachment 240759 [details]
Patch

Clearing flags on attachment: 240759

Committed r175433: <http://trac.webkit.org/changeset/175433>
Comment 6 WebKit Commit Bot 2014-10-31 16:14:51 PDT 
All reviewed patches have been landed.  Closing bug.