Bug 138255 - Make writes to RegExpObject.lastIndex cacheable.
Summary: Make writes to RegExpObject.lastIndex cacheable.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on:
Blocks:
 
Reported: 2014-10-31 11:12 PDT by Andreas Kling
Modified: 2014-10-31 12:28 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.24 KB, patch)
2014-10-31 11:13 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-10-31 11:12:49 PDT 
We're not caching writes to RegExpObject.lastIndex. Let's try doing that.
Comment 1 Andreas Kling 2014-10-31 11:13:39 PDT 
Created attachment 240745 [details]
Patch
Comment 2 Geoffrey Garen 2014-10-31 11:33:47 PDT 
Comment on attachment 240745 [details]
Patch

IC is nice. It's probably even nicer just to make lastIndex a vanilla JS property.
Comment 3 Andreas Kling 2014-10-31 11:50:01 PDT 
(In reply to comment #2)
> Comment on attachment 240745 [details]
> Patch
> 
> IC is nice. It's probably even nicer just to make lastIndex a vanilla JS
> property.

Yeah. I'll land this, but let's talk about that.
Comment 4 WebKit Commit Bot 2014-10-31 12:28:09 PDT 
Comment on attachment 240745 [details]
Patch

Clearing flags on attachment: 240745

Committed r175416: <http://trac.webkit.org/changeset/175416>
Comment 5 WebKit Commit Bot 2014-10-31 12:28:12 PDT 
All reviewed patches have been landed.  Closing bug.