Bug 138248 - Type clash warnings in CSSGrammar.y
Summary: Type clash warnings in CSSGrammar.y
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-31 07:13 PDT by Akos Kiss
Modified: 2014-10-31 12:11 PDT (History)
4 users (show)

See Also:

Attachments
Proposed patch. (1.19 KB, patch)
2014-10-31 07:19 PDT, Akos Kiss 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Akos Kiss 2014-10-31 07:13:04 PDT 
When building WebKit (release, for x86-64/Linux/GTK, but actually there is/should be nothing platform or port-specific in the issue), bison is emitting the following warnings:

[190/4820] Generating ../../DerivedSources/WebCore/CSSGrammar.h, ../../DerivedSources/WebCore/CSSGrammar.cpp
/home/akiss/devel/WebKit/WebKitBuild/Release/DerivedSources/WebCore/CSSGrammar.y:576.17-25: warning: type clash on default action: <boolean> != <> [-Wother]
 supports_error: error ';' | error invalid_block ;
                 ^^^^^^^^^
/home/akiss/devel/WebKit/WebKitBuild/Release/DerivedSources/WebCore/CSSGrammar.y:576.29-47: warning: type clash on default action: <boolean> != <> [-Wother]
 supports_error: error ';' | error invalid_block ;
                             ^^^^^^^^^^^^^^^^^^^

Actually, this causes no issues when running the generated code but it would be cleaner to get rid of the warnings and make bison happy, IMHO.
Comment 1 Akos Kiss 2014-10-31 07:19:33 PDT 
Created attachment 240733 [details]
Proposed patch.

Caused no regression.
Comment 2 WebKit Commit Bot 2014-10-31 12:10:58 PDT 
Comment on attachment 240733 [details]
Proposed patch.

Clearing flags on attachment: 240733

Committed r175415: <http://trac.webkit.org/changeset/175415>
Comment 3 WebKit Commit Bot 2014-10-31 12:11:03 PDT 
All reviewed patches have been landed.  Closing bug.