Bug 138241 – AX:setSelectedRows loop is incorrect -- ignores the count

• Status: NEW
• Component: Accessibility

[chris fleizach]

From:
https://bugs.webkit.org/show_bug.cgi?id=126915#c12

> >> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1650
> >> +    for (const auto& selectedRow : selectedRows)
> > 
> > I don't believe this change is correct. It ignores the count variable that is set above depending on isMultiSelectable() so I am assuming we can now select more than 1 row even if it is not multiSelectable.
> 
> I think you're right too

This was reported by clang static analyzer.
Would you mind making the fix? I don't feel like writing the layout test for this :)

[Radar WebKit Bug Importer]

<rdar://problem/18834530>

[Radar WebKit Bug Importer]

<rdar://problem/18834534>

[Matthew Daiter]

Created attachment 257963 [details]
Patch

[Matthew Daiter]

Is this what you were trying to do?

[chris fleizach]

Comment on attachment 257963 [details]
Patch

is it possible to add a layout test?
thanks

[Joseph Pecoraro]

Comment on attachment 257963 [details]
Patch

This issue still exists because this never landed. The static analyzer warning still exists. This never landed because there was no test. Any ideas on how to write one?

[chris fleizach]

Comment on attachment 257963 [details]
Patch

I think a layout test would try to use the accessibility setSelectedRows method with more than 1 item on a non-multi-selectable selection box, then verify that only one row is selected.