Bug 138230 – Clean up virtual functions in css/

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Chris Dumez]

Clean up virtual functions in css/ by:
- Making virtual functions final when possible
- Making classes final when possible
- Using 'override' when appropriate
- Explicitly marking functions / destructors as virtual when they are
  inherently virtual
- Making isXXX() virtual functions private on XXX classes to avoid
  unnecessary type checks

[Chris Dumez]

Created attachment 240696 [details]
Patch

[Benjamin Poulain]

Comment on attachment 240696 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240696&action=review

> Source/WebCore/css/CSSRuleList.h:62
> +    virtual CSSStyleSheet* styleSheet() const override { return 0; }

0 -> nullptr

> Source/WebCore/css/CSSRuleList.h:69
> +    virtual CSSRule* item(unsigned index) const override { return index < m_rules.size() ? m_rules[index].get() : 0; }

ditto

I wonder why it is valid to ask for a rule index > length...

[Chris Dumez]

Comment on attachment 240696 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240696&action=review

>> Source/WebCore/css/CSSRuleList.h:69
>> +    virtual CSSRule* item(unsigned index) const override { return index < m_rules.size() ? m_rules[index].get() : 0; }
> 
> ditto
> 
> I wonder why it is valid to ask for a rule index > length...

The spec says so: http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSSRuleList

[Chris Dumez]

Created attachment 240707 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 240707 [details]
Patch

Clearing flags on attachment: 240707

Committed r175391: <http://trac.webkit.org/changeset/175391>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.