Bug 138228 - Migrate ComplexTextControllerCoreText to use SPI instead of WKSI
Summary: Migrate ComplexTextControllerCoreText to use SPI instead of WKSI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-30 14:08 PDT by Myles C. Maxfield
Modified: 2014-10-30 14:17 PDT (History)
5 users (show)

See Also:

Attachments
Patch (7.51 KB, patch)
2014-10-30 14:09 PDT, Myles C. Maxfield 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-10-30 14:08:17 PDT 
Migrate ComplexTextControllerCoreText to use SPI instead of WKSI
Comment 1 Myles C. Maxfield 2014-10-30 14:09:53 PDT 
Created attachment 240694 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-10-30 14:12:01 PDT 
Comment on attachment 240694 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240694&action=review

> Source/WebCore/platform/spi/cocoa/CoreTextSPI.h:40
> +extern "C" CGSize CTRunGetInitialAdvance(CTRunRef run);
> +extern "C" CTLineRef CTLineCreateWithUniCharProvider(CTUniCharProviderCallback provide, CTUniCharDisposeCallback dispose, void* refCon);
> +extern "C" CTTypesetterRef CTTypesetterCreateWithUniCharProviderAndOptions(CTUniCharProviderCallback provide, CTUniCharDisposeCallback dispose, void* refCon, CFDictionaryRef options);

Maybe use an extern "C" {} block
Comment 3 Myles C. Maxfield 2014-10-30 14:17:45 PDT 
https://trac.webkit.org/r175379