Currently bisect-builds only works with Safari. I propose that we add an argument that allows users to specify which application should be run against the nightly WebKit frameworks.
Created attachment 240693 [details] Patch
<rdar://problem/18829294>
Comment on attachment 240693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240693&action=review r=me with comments addressed. > Tools/Scripts/bisect-builds:38 > -# $safariPath = "/path/to/Safari.app"; > +# $applicationPath = "/path/to/Application.app"; This should not change unless we're going to support $Settings::applicationPath and remove $Settings::safariPath. Or keep $safariPath and add $applicationPath here. # $safariPath = "/path/to/Safari.app"; + # $applicationPath = "/path/to/Application.app"; > Tools/Scripts/bisect-builds:73 > my $safariPath = $Settings::safariPath; > +my $applicationPath; I would expect this to be change to the following if we were supported in the ~/.bisect-buildsrc file: my $applicationPath = $Settings:: applicationPath; > Tools/Scripts/bisect-builds:430 > + # Check for both appliactions and application bundles. Typo: appliactions > Tools/Scripts/bisect-builds:436 > + push @args, "--args", "-ApplePersistenceIgnoreState", "YES" if $isBundle; Very nice. Should we only do this if $safariPath is set instead of $isBundle? push @args, "--args", "-ApplePersistenceIgnoreState", "YES" if $safariPath; Or does this work for multiple apps?
Comment on attachment 240693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240693&action=review Thanks for the review! >> Tools/Scripts/bisect-builds:38 >> +# $applicationPath = "/path/to/Application.app"; > > This should not change unless we're going to support $Settings::applicationPath and remove $Settings::safariPath. Or keep $safariPath and add $applicationPath here. > > # $safariPath = "/path/to/Safari.app"; > + # $applicationPath = "/path/to/Application.app"; I noticed this after sending out this patch. I'll keep it set to $safariPath here. This might be a good thing to change/add in a future patch. >> Tools/Scripts/bisect-builds:73 >> +my $applicationPath; > > I would expect this to be change to the following if we were supported in the ~/.bisect-buildsrc file: > > my $applicationPath = $Settings:: applicationPath; See above. >> Tools/Scripts/bisect-builds:436 >> + push @args, "--args", "-ApplePersistenceIgnoreState", "YES" if $isBundle; > > Very nice. Should we only do this if $safariPath is set instead of $isBundle? > > push @args, "--args", "-ApplePersistenceIgnoreState", "YES" if $safariPath; > > Or does this work for multiple apps? This works with multiple apps. I have tested it with Mail and iTunes so far, but I would expect it to work with others.
Committed r175401: <http://trac.webkit.org/changeset/175401>
*** Bug 137577 has been marked as a duplicate of this bug. ***