Long spins under rangeExpandedAroundPosition on Yahoo Mail
Created attachment 240687 [details] Patch
Comment on attachment 240687 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240687&action=review > Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:517 > + end = end.previous(Character); What happens when you reach a null position before the number of characters to expand? I think you should handle that case in both directions.
Comment on attachment 240687 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240687&action=review >> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:517 >> + end = end.previous(Character); > > What happens when you reach a null position before the number of characters to expand? I think you should handle that case in both directions. Interesting! I'm surprised the telephone number code I stole this from has never been a problem.
It looks like the positions never become null, they just climb the tree and then stick at one end or the other. Works exactly as you'd hope.
Comment on attachment 240687 [details] Patch Thanks for looking into that!. Looks good to me.
http://trac.webkit.org/changeset/175388