Bug 138210 - [GTK] Minibrowser : Add keyborad support for creating new window in GTK Minibrowser
Summary: [GTK] Minibrowser : Add keyborad support for creating new window in GTK Minib...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-30 02:55 PDT by Rohit
Modified: 2017-03-11 10:49 PST (History)
10 users (show)

See Also:

Attachments
Patch (2.38 KB, patch)
2014-10-30 03:05 PDT, Rohit 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rohit 2014-10-30 02:55:21 PDT 
Add keyboard support for creating new window in Webkit GTK Minibrowser using 'ctrl' + 'n' keys.
Comment 1 Rohit 2014-10-30 03:05:23 PDT 
Created attachment 240664 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-05-15 04:44:55 PDT 
cc-ing more GTK reviewer
Comment 3 Michael Catanzaro 2016-01-06 20:24:49 PST 
Comment on attachment 240664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240664&action=review

Thanks, sorry for the late review.

> Tools/ChangeLog:3
> +        [GTK] Minibrowser : Add keyborad support for creating new window in GTK Minibrowser

keyborad -> keyboard

> Tools/MiniBrowser/gtk/BrowserWindow.c:566
> +static void createNewWindow(BrowserWindow *window, gpointer user_data)

user_data -> userData