Bug 138205 - Add diagnostic logging to track page loads.
Summary: Add diagnostic logging to track page loads.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-10-29 18:45 PDT by Eric Carlson
Modified: 2015-02-20 15:47 PST (History)
4 users (show)

See Also:

Attachments
Proposed patch. (3.15 KB, patch)
2014-10-29 19:17 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Updated patch (3.15 KB, patch)
2014-10-29 19:28 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2014-10-29 18:45:57 PDT 
Add diagnostic logging to track the number of page loads.
Comment 1 Eric Carlson 2014-10-29 18:46:40 PDT 
<rdar://problem/18173017>
Comment 2 Radar WebKit Bug Importer 2014-10-29 18:47:01 PDT 
<rdar://problem/18820041>
Comment 3 Eric Carlson 2014-10-29 19:17:45 PDT 
Created attachment 240649 [details]
Proposed patch.
Comment 4 WebKit Commit Bot 2014-10-29 19:19:03 PDT 
Attachment 240649 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/FrameLoader.cpp:47:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Eric Carlson 2014-10-29 19:28:13 PDT 
Created attachment 240650 [details]
Updated patch

> ERROR: Source/WebCore/loader/FrameLoader.cpp:47:  Alphabetical sorting problem.  [build/include_order] [4]

Oh the horror!
Comment 6 WebKit Commit Bot 2014-10-30 12:04:31 PDT 
Comment on attachment 240650 [details]
Updated patch

Clearing flags on attachment: 240650

Committed r175375: <http://trac.webkit.org/changeset/175375>
Comment 7 WebKit Commit Bot 2014-10-30 12:04:38 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Chris Dumez 2015-02-20 15:47:53 PST 
Comment on attachment 240650 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240650&action=review

> Source/WebCore/loader/FrameLoader.cpp:2270
> +            page->chrome().client().logDiagnosticMessage(DiagnosticLoggingKeys::pageLoadedKey(), emptyString(), error.isNull() ? DiagnosticLoggingKeys::passKey() : DiagnosticLoggingKeys::failKey());

This seems to log for each frame load (included subframes). Was this the intention?