Bug 138202 - Optimize HTMLVideoElement / HTMLAudioElement type checks a bit
Summary: Optimize HTMLVideoElement / HTMLAudioElement type checks a bit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 138322
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-29 17:46 PDT by Chris Dumez
Modified: 2014-11-03 12:44 PST (History)
6 users (show)

See Also:


Attachments
Patch (8.09 KB, patch)
2014-10-29 19:54 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (8.66 KB, patch)
2014-10-29 20:02 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (8.88 KB, patch)
2014-10-29 20:07 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-10-29 17:46:22 PDT
Optimize HTMLVideoElement / HTMLAudioElement type checks a bit by:
1. using is<HTMLMediaElement>() instead of is<HTMLVideoElement>() || is<HTMLAudioElement>() if the caller is interested in both video and audio elements
2. Updating HTMLVideoElement / HTMLAudioElement type traits specialization to avoid doing an isHTMLUnknownElement() check if the input type is an HTMLMediaElement (which is common in the code base)
Comment 1 Chris Dumez 2014-10-29 19:54:16 PDT
Created attachment 240651 [details]
Patch
Comment 2 Chris Dumez 2014-10-29 20:02:10 PDT
Created attachment 240652 [details]
Patch
Comment 3 Chris Dumez 2014-10-29 20:07:23 PDT
Created attachment 240653 [details]
Patch
Comment 4 WebKit Commit Bot 2014-10-30 14:25:32 PDT
Comment on attachment 240653 [details]
Patch

Clearing flags on attachment: 240653

Committed r175380: <http://trac.webkit.org/changeset/175380>
Comment 5 WebKit Commit Bot 2014-10-30 14:25:36 PDT
All reviewed patches have been landed.  Closing bug.