Bug 138190 – Clean up virtual functions in inspector/

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Chris Dumez]

Clean up virtual functions in inspector/ by:
- Making virtual functions final when possible
- Making classes final when possible
- Explicitly marking functions / destructors as virtual when they are
  inherently virtual
- Making isXXX() virtual functions private on XXX classes to avoid
      unnecessary type checks

[Radar WebKit Bug Importer]

<rdar://problem/18817528>

[Chris Dumez]

Created attachment 240631 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 240631 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240631&action=review

r=me!

> Source/WebCore/inspector/PageConsoleAgent.h:50
> -    virtual bool isWorkerAgent() const override { return false; }
> -
>  private:
> +    virtual bool isWorkerAgent() const override { return false; }

I never really understood this (moving public virtual functions to private). They are still public, so why not leave it public?

[Chris Dumez]

Comment on attachment 240631 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240631&action=review

>> Source/WebCore/inspector/PageConsoleAgent.h:50
>> +    virtual bool isWorkerAgent() const override { return false; }
> 
> I never really understood this (moving public virtual functions to private). They are still public, so why not leave it public?

Calling PageConsoleAgent::isWorkerAgent() should give you a compile error now because it *is* private (if the instance is a PageConsoleAgent, not a generic WebConsoleAgent). This makes sure we don't do unnecessary type checks in the code as explained in the Changelog.

[WebKit Commit Bot]

Comment on attachment 240631 [details]
Patch

Clearing flags on attachment: 240631

Committed r175355: <http://trac.webkit.org/changeset/175355>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.