RESOLVED FIXED Bug 138185
Web Inspector: I do not expect to see the same rule multiple times in styles sidebar 
https://bugs.webkit.org/show_bug.cgi?id=138185
Summary Web Inspector: I do not expect to see the same rule multiple times in styles ...
Joseph Pecoraro
Reported 2014-10-29 14:23:52 PDT
* SUMMARY When a rule with multiple selectors matching the current selected element, the rule shows up multiple times in the sidebar. * TEST <style>*, h1, .a, h1.a, body > #foo.a.b { color: green; }</style> <h1 id="foo" class="a b c">Hello World</h1> * STEPS TO REPRODUCE 1. Inspect h1#foo on test page 2. Show styles sidebar => See the one rule 5 times * NOTES It is not too unreasonable to show this rule multiple times. For instance in this test: <style> h1, h1.a { color: blue } .a { color: red; } </style> <h1 class="a">Test</h1> Which will show the fallback list as: Rule 1 (h1.a) -> Rule 2 (.a) -> Rule 1 (a) However, in the case where the same rule matches multiple times, it seems the case of higher specificity should show, and the others do not need to. * OTHER BROWSERS - Chrome matches Safari now and shows the rule multiple times - Firefox only shows the rule once Thoughts?
Attachments
[PATCH] Proposed Fix (3.97 KB, patch)
2014-12-01 17:12 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (3.98 KB, patch)
2014-12-01 17:14 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-10-29 14:24:24 PDT
<rdar://problem/18816349>
Joseph Pecoraro
Comment 2 2014-10-29 14:24:46 PDT
Probably a dup of: https://bugs.webkit.org/show_bug.cgi?id=113476 I rather like the idea of reducing clutter.
Timothy Hatcher
Comment 3 2014-10-29 14:27:03 PDT
I debated this when I redid the sidebar. It can be important when each selector has different specificity and other rules interleave with it. Different CSS properties could/will be overridden in each instance of the rule with multiple selectors.
Timothy Hatcher
Comment 4 2014-10-29 14:27:39 PDT
Maybe we can show them but in some new collapsed state?
Timothy Hatcher
Comment 5 2014-10-29 14:29:14 PDT
Or only show them if interleaving happens. Otherwise it collapses into one instance.
Joseph Pecoraro
Comment 6 2014-12-01 17:09:39 PST
I think the deduplication really helps simplify the sidebar. One case I hadn't thought of that this helps is inherited styles. Take this test: <html> <head> <style> /* simplified reset.css */ html, body, div, p { margin:0; padding:0; border:0; font-style: inherit; } body { line-height:1.5; } /* page styles */ p { margin: 0 0 1.5em; } </style> </head> <body><div><p>Test</p></div></body> </html> Inspecting the <p> you will see the first reset rule 4 times total because of the "font-style: inherit" for the p, div, body, html. With de-duplication you only see it once, up above with high specificity and never in the inherited section. If there was in fact a font style it inherits, that would be listed in the inherited section, seriously reducing clutter.
Joseph Pecoraro
Comment 7 2014-12-01 17:12:36 PST
Created attachment 242365 [details] [PATCH] Proposed Fix We should probably also include the complete fallback list in the Computed Rules section with the complete cascade per-property like Firefox/Chrome if there is ever a case where interleaving matters.
Joseph Pecoraro
Comment 8 2014-12-01 17:13:51 PST
Comment on attachment 242365 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=242365&action=review > Source/WebInspectorUI/ChangeLog:18 > + Remove duplicates from the ordered list of selectors. s/selectors/CSSStyleDeclarations/
Joseph Pecoraro
Comment 9 2014-12-01 17:14:26 PST
Created attachment 242367 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 10 2015-01-13 13:44:20 PST
Comment on attachment 242367 [details] [PATCH] Proposed Fix Clearing flags on attachment: 242367 Committed r178373: <http://trac.webkit.org/changeset/178373>
WebKit Commit Bot
Comment 11 2015-01-13 13:44:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.