Bug 138178 – Implement action menus for data detected items

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Tim Horton]

<rdar://problem/18709436>

[Tim Horton]

Created attachment 240611 [details]
patch

[WebKit Commit Bot]

Attachment 240611 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:63:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: WebKitLibraries/WebKitSystemInterface.h:132:  The parameter name "controlSize" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: WebKitLibraries/WebKitSystemInterface.h:134:  The parameter name "actionContext" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/Shared/mac/ActionMenuHitTestResult.mm:84:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/mac/ActionMenuHitTestResult.mm:84:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 5 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Comment on attachment 240611 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240611&action=review

> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:400
> +            DDActionContext *actionContext = _hitTestResult.actionContext.get();
> +            if (actionContext) {

Can put these on a single line.

[Tim Horton]

http://trac.webkit.org/changeset/175335

[Chris Dumez]

Comment on attachment 240611 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240611&action=review

> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:401
> +                WKSetDDActionContextIsForActionMenu(actionContext);

My build fails saying this one is undefined.

[Tim Horton]

(In reply to comment #5)
> Comment on attachment 240611 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240611&action=review
> 
> > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:401
> > +                WKSetDDActionContextIsForActionMenu(actionContext);
> 
> My build fails saying this one is undefined.

We sorted this out.