Bug 138178 - Implement action menus for data detected items
Summary: Implement action menus for data detected items
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-29 10:41 PDT by Tim Horton
Modified: 2014-10-29 15:14 PDT (History)
8 users (show)

See Also:

Attachments
patch (318.23 KB, patch)
2014-10-29 10:50 PDT, Tim Horton 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-10-29 10:41:51 PDT 
<rdar://problem/18709436>
Comment 1 Tim Horton 2014-10-29 10:50:04 PDT 
Created attachment 240611 [details]
patch
Comment 2 WebKit Commit Bot 2014-10-29 10:53:19 PDT 
Attachment 240611 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:63:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: WebKitLibraries/WebKitSystemInterface.h:132:  The parameter name "controlSize" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: WebKitLibraries/WebKitSystemInterface.h:134:  The parameter name "actionContext" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/Shared/mac/ActionMenuHitTestResult.mm:84:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/mac/ActionMenuHitTestResult.mm:84:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 5 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2014-10-29 11:42:51 PDT 
Comment on attachment 240611 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240611&action=review

> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:400
> +            DDActionContext *actionContext = _hitTestResult.actionContext.get();
> +            if (actionContext) {

Can put these on a single line.
Comment 4 Tim Horton 2014-10-29 11:48:30 PDT 
http://trac.webkit.org/changeset/175335
Comment 5 Chris Dumez 2014-10-29 15:03:11 PDT 
Comment on attachment 240611 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240611&action=review

> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:401
> +                WKSetDDActionContextIsForActionMenu(actionContext);

My build fails saying this one is undefined.
Comment 6 Tim Horton 2014-10-29 15:14:33 PDT 
(In reply to comment #5)
> Comment on attachment 240611 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240611&action=review
> 
> > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:401
> > +                WKSetDDActionContextIsForActionMenu(actionContext);
> 
> My build fails saying this one is undefined.

We sorted this out.