Bug 138175 - [EME][Mac] MediaKeySession type "keyrelease" is ignored.
Summary: [EME][Mac] MediaKeySession type "keyrelease" is ignored.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-10-29 08:47 PDT by Jer Noble
Modified: 2014-12-16 13:28 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.40 KB, patch)
2014-10-29 09:16 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-10-29 08:47:48 PDT 
[EME][Mac] MediaKeySession type "keyrelease" is ignored.
Comment 1 Jer Noble 2014-10-29 09:16:22 PDT 
Created attachment 240604 [details]
Patch
Comment 2 Eric Carlson 2014-10-29 09:38:46 PDT 
Comment on attachment 240604 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240604&action=review

acknowledged

> Source/WebCore/ChangeLog:12
> +        Also, the code which validates update() requests needs to allow updates of containing the string

Nit: "... allow updates OF containing ..." => "... allow updates containing ..."

> Source/WebCore/ChangeLog:13
> +        "acknowledeged", so that clients can request the confirmation messages be discarded.

Nit: "acknowledeged" => "acknowledged"

> Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:202
> +    if (m_mode == KeyRelease)
> +        return false;
> +

Does this add support for "acknowledged"?
Comment 3 Jer Noble 2014-10-29 10:47:38 PDT 
Comment on attachment 240604 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240604&action=review

>> Source/WebCore/ChangeLog:12
>> +        Also, the code which validates update() requests needs to allow updates of containing the string
> 
> Nit: "... allow updates OF containing ..." => "... allow updates containing ..."

Changed.

>> Source/WebCore/ChangeLog:13
>> +        "acknowledeged", so that clients can request the confirmation messages be discarded.
> 
> Nit: "acknowledeged" => "acknowledged"

Changed.

>> Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:202
>> +
> 
> Does this add support for "acknowledged"?

Only for "keyrelease" sessions.  "acknowledged" was already working for the normal flow, i.e., when calling mediaKeySession.stop().
Comment 4 Jer Noble 2014-10-29 10:54:08 PDT 
Committed r175331: <http://trac.webkit.org/changeset/175331>
Comment 5 Jer Noble 2014-12-16 13:28:33 PST 
<rdar://problem/19269059>