RESOLVED FIXED 138166
Clean up virtual functions in html/ 
https://bugs.webkit.org/show_bug.cgi?id=138166
Summary Clean up virtual functions in html/
Chris Dumez
Reported 2014-10-28 21:02:43 PDT
Clean up virtual functions in html/ by: - Making virtual functions final when possible - Making classes final when possible - Using 'override' when appropriate - Explicitly marking functions / destructors as virtual when they are inherently virtual - Dropping virtual destructors when the class does not have subclasses and mark the class as final, to get rid of unnecessary vtables - Making isXXX() virtual functions private on XXX classes to avoid unnecessary type checks - De-virtualizing some functions that do not need to be virtual - Dropping final for virtual functions in classes already marked as final
Attachments
Patch (75.88 KB, patch)
2014-10-28 21:21 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-10-28 21:21:48 PDT
Created attachment 240592 [details] Patch
Andreas Kling
Comment 2 2014-10-29 00:11:06 PDT
Comment on attachment 240592 [details] Patch r=me!
WebKit Commit Bot
Comment 3 2014-10-29 08:09:59 PDT
Comment on attachment 240592 [details] Patch Clearing flags on attachment: 240592 Committed r175328: <http://trac.webkit.org/changeset/175328>
WebKit Commit Bot
Comment 4 2014-10-29 08:10:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.