Bug 138166 - Clean up virtual functions in html/
Summary: Clean up virtual functions in html/
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Depends on:
Reported: 2014-10-28 21:02 PDT by Chris Dumez
Modified: 2014-10-29 08:10 PDT (History)
6 users (show)

See Also:

Patch (75.88 KB, patch)
2014-10-28 21:21 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-10-28 21:02:43 PDT
Clean up virtual functions in html/ by:
- Making virtual functions final when possible
- Making classes final when possible
- Using 'override' when appropriate
- Explicitly marking functions / destructors as virtual when they are
  inherently virtual
- Dropping virtual destructors when the class does not have subclasses
  and mark the class as final, to get rid of unnecessary vtables
- Making isXXX() virtual functions private on XXX classes to avoid
  unnecessary type checks
- De-virtualizing some functions that do not need to be virtual
- Dropping final for virtual functions in classes already marked as
Comment 1 Chris Dumez 2014-10-28 21:21:48 PDT
Created attachment 240592 [details]
Comment 2 Andreas Kling 2014-10-29 00:11:06 PDT
Comment on attachment 240592 [details]

Comment 3 WebKit Commit Bot 2014-10-29 08:09:59 PDT
Comment on attachment 240592 [details]

Clearing flags on attachment: 240592

Committed r175328: <http://trac.webkit.org/changeset/175328>
Comment 4 WebKit Commit Bot 2014-10-29 08:10:04 PDT
All reviewed patches have been landed.  Closing bug.