Bug 138160 - Unify logic in RunTests.run() to run the Python unit tests
Summary: Unify logic in RunTests.run() to run the Python unit tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on: 137667
Blocks:
  Show dependency tree / graph
 
Reported: 2014-10-28 17:13 PDT by Daniel Bates
Modified: 2014-10-28 18:28 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.39 KB, patch)
2014-10-28 17:34 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (3.39 KB, patch)
2014-10-28 18:03 PDT, Daniel Bates 		mrobinson: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2014-10-28 17:13:44 PDT 
Currently we duplicate logic when running the RunTest step interactively and non-interacrtively for determining the path to the test-webkitpy application and printing a log message to the console to inform a person that we are running the Python unit tests. We should unify these code paths.
Comment 1 Daniel Bates 2014-10-28 17:34:11 PDT 
Created attachment 240583 [details]
Patch
Comment 2 Daniel Bates 2014-10-28 18:03:04 PDT 
Created attachment 240584 [details]
Patch

Rebased patch following the landing of the patch for bug #137667.
Comment 3 Daniel Bates 2014-10-28 18:28:31 PDT 
Committed r175295: <http://trac.webkit.org/changeset/175295>