Bug 138158 - Implement WKPageSetMuted(bool)
Summary: Implement WKPageSetMuted(bool)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords:
Depends on: 138150
Blocks:
  Show dependency tree / graph
 
Reported: 2014-10-28 16:49 PDT by Ada Chan
Modified: 2014-10-29 16:01 PDT (History)
3 users (show)

See Also:

Attachments
Patch (7.52 KB, patch)
2014-10-29 13:06 PDT, Ada Chan 		no flags Details | Formatted Diff | Diff
Patch, fixed the ordering issue in WebCore.exp.in (7.60 KB, patch)
2014-10-29 13:23 PDT, Ada Chan 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2014-10-28 16:49:22 PDT 
Implement WKPageSetMuted(bool).

Needed for <rdar://problem/18398191>.
Comment 1 Ada Chan 2014-10-29 13:06:19 PDT 
Created attachment 240615 [details]
Patch
Comment 2 WebKit Commit Bot 2014-10-29 13:07:49 PDT 
Attachment 240615 [details] did not pass style-queue:


ERROR: Source/WebCore/WebCore.exp.in:0:  Source/WebCore/WebCore.exp.in should be sorted, use Tools/Scripts/sort-export-file script  [list/order] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ada Chan 2014-10-29 13:23:59 PDT 
Created attachment 240617 [details]
Patch, fixed the ordering issue in WebCore.exp.in
Comment 4 Anders Carlsson 2014-10-29 14:30:38 PDT 
Comment on attachment 240617 [details]
Patch, fixed the ordering issue in WebCore.exp.in

I think you also need to pass "muted" as a web page creation parameter so you'll handle the web process crashing. This is a good start though!
Comment 5 Ada Chan 2014-10-29 15:57:45 PDT 
Thanks Anders!  I've filed https://bugs.webkit.org/show_bug.cgi?id=138195 to handle restoring the muted state after web process crashes.
Comment 6 Ada Chan 2014-10-29 16:01:26 PDT 
Committed:
http://trac.webkit.org/changeset/175351