Bug 138153 - Remove MediaSessionClient::hasMediaCharacteristics() and MediaSessionClient::mediaStateDidChange()
Summary: Remove MediaSessionClient::hasMediaCharacteristics() and MediaSessionClient::...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-28 15:15 PDT by Ada Chan
Modified: 2014-10-29 10:42 PDT (History)
9 users (show)

See Also:

Attachments
Patch (10.25 KB, patch)
2014-10-28 16:34 PDT, Ada Chan 		jer.noble: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2014-10-28 15:15:14 PDT 
After http://trac.webkit.org/changeset/175273, Document no longer keeps a set of MediaSessions and it doesn't need to query each MediaSession for its characteristics and play state.  MediaSessionClient::hasMediaCharacteristics() is no longer needed and MediaSessionClient::mediaStateDidChange() can be removed if HTMLMediaElement calls Document::updateIsPlayingAudio() after m_playing has changed.
Comment 1 Ada Chan 2014-10-28 16:34:10 PDT 
Created attachment 240576 [details]
Patch
Comment 2 Jer Noble 2014-10-29 10:17:33 PDT 
Comment on attachment 240576 [details]
Patch

r=me, with one nit: The comment you made above is really good, and I'd like to see it in the ChangeLog too.
Comment 3 Ada Chan 2014-10-29 10:42:17 PDT 
Thanks Jer.

Committed:
http://trac.webkit.org/changeset/175330