WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
138152
Generalize dirtying of parent's line boxes when taking a renderer out of tree.
https://bugs.webkit.org/show_bug.cgi?id=138152
Summary
Generalize dirtying of parent's line boxes when taking a renderer out of tree.
Andreas Kling
Reported
2014-10-28 15:08:34 PDT
We currently have calls to dirtyLinesFromChangedChild() scattered in various subclass implementations of RenderObject::willBeDestroyed(). I think we can do this in RenderElement::willBeRemovedFromTree() instead. It makes more sense to me that the act of removing the renderer from the tree is what dirties other things on the same line, not its actual destruction.
Attachments
Patch
(4.99 KB, patch)
2014-10-28 15:09 PDT
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2014-10-28 15:09:06 PDT
Created
attachment 240573
[details]
Patch
WebKit Commit Bot
Comment 2
2014-10-29 16:02:07 PDT
Comment on
attachment 240573
[details]
Patch Clearing flags on attachment: 240573 Committed
r175352
: <
http://trac.webkit.org/changeset/175352
>
WebKit Commit Bot
Comment 3
2014-10-29 16:02:10 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug