Bug 138152 - Generalize dirtying of parent's line boxes when taking a renderer out of tree.
Summary: Generalize dirtying of parent's line boxes when taking a renderer out of tree.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-28 15:08 PDT by Andreas Kling
Modified: 2014-10-29 16:02 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.99 KB, patch)
2014-10-28 15:09 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-10-28 15:08:34 PDT 
We currently have calls to dirtyLinesFromChangedChild() scattered in various subclass implementations of RenderObject::willBeDestroyed().

I think we can do this in RenderElement::willBeRemovedFromTree() instead. It makes more sense to me that the act of removing the renderer from the tree is what dirties other things on the same line, not its actual destruction.
Comment 1 Andreas Kling 2014-10-28 15:09:06 PDT 
Created attachment 240573 [details]
Patch
Comment 2 WebKit Commit Bot 2014-10-29 16:02:07 PDT 
Comment on attachment 240573 [details]
Patch

Clearing flags on attachment: 240573

Committed r175352: <http://trac.webkit.org/changeset/175352>
Comment 3 WebKit Commit Bot 2014-10-29 16:02:10 PDT 
All reviewed patches have been landed.  Closing bug.