Bug 138148 - Clean up virtual functions in accessibility/
Summary: Clean up virtual functions in accessibility/
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Keywords: InRadar
Depends on:
Reported: 2014-10-28 14:18 PDT by Chris Dumez
Modified: 2014-10-28 15:42 PDT (History)
17 users (show)

See Also:

Patch (36.09 KB, patch)
2014-10-28 14:55 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-10-28 14:18:40 PDT
Clean up virtual functions in accessibility/ by:
- Marking classes as final when suitable
- Marking virtual functions as final when suitable
- Dropping final on virtual functions in classes that are already final
- Make isXXX() virtual type checking functions in XXX classes to avoid useless type checks
Comment 1 Radar WebKit Bug Importer 2014-10-28 14:18:56 PDT
Comment 2 Chris Dumez 2014-10-28 14:55:38 PDT
Created attachment 240572 [details]
Comment 3 WebKit Commit Bot 2014-10-28 15:42:34 PDT
Comment on attachment 240572 [details]

Clearing flags on attachment: 240572

Committed r175278: <http://trac.webkit.org/changeset/175278>
Comment 4 WebKit Commit Bot 2014-10-28 15:42:39 PDT
All reviewed patches have been landed.  Closing bug.