Bug 138144 - [Cocoa] REGERESSION (r171801): Client certificate authentication is failing
Summary: [Cocoa] REGERESSION (r171801): Client certificate authentication is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2014-10-28 12:51 PDT by mitz
Modified: 2014-10-28 13:03 PDT (History)
1 user (show)

See Also:

Attachments
Encode the individual pieces of identity-based credentials separately (3.53 KB, patch)
2014-10-28 12:57 PDT, mitz 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-10-28 12:51:23 PDT 
<http://trac.webkit.org/r171801> broke client certificate authentication, because NSURLCredential doesn’t serialize identities properly. Patch forthcoming.
Comment 1 mitz 2014-10-28 12:57:52 PDT 
Created attachment 240564 [details]
Encode the individual pieces of identity-based credentials separately
Comment 2 Alexey Proskuryakov 2014-10-28 13:00:23 PDT 
Comment on attachment 240564 [details]
Encode the individual pieces of identity-based credentials separately

View in context: https://bugs.webkit.org/attachment.cgi?id=240564&action=review

> Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:286
> +    // NSURLCredential doesn't serialize identities correctly, so we encode the pieces individually in the identity case.

Is there a bug tracking a fix for this incorrectness?
Comment 3 mitz 2014-10-28 13:01:57 PDT 
Fixed in <http://trac.webkit.org/r175270>.
Comment 4 mitz 2014-10-28 13:03:38 PDT 
(In reply to comment #2)
> Comment on attachment 240564 [details]
> Encode the individual pieces of identity-based credentials separately
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240564&action=review
> 
> > Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:286
> > +    // NSURLCredential doesn't serialize identities correctly, so we encode the pieces individually in the identity case.
> 
> Is there a bug tracking a fix for this incorrectness?

I don’t know. If there is, it will be in Radar, not in bugs.webkit.org.