RESOLVED FIXED138119
Simplified some JSObject methods for converting arrays to ArrayStorage shape 
https://bugs.webkit.org/show_bug.cgi?id=138119
Summary Simplified some JSObject methods for converting arrays to ArrayStorage shape
Mark Lam
Reported 2014-10-27 19:41:51 PDT
Currently, for each Undecided, Int32, Double, and Contiguous array shapes, there are 3 JSObject methods to convert them to ArrayStorage shape: ArrayStorage* convert<shape>ToArrayStorage(VM&, NonPropertyTransition, unsigned neededLength); ArrayStorage* convert<shape>ToArrayStorage(VM&, NonPropertyTransition); ArrayStorage* convert<shape>ToArrayStorage(VM&); However, the neededLength that is passed is always m_butterfly->vectorLength(). Hence, the method that takes a neededLength is really not needed.
Attachments
the patch. (8.29 KB, patch)
2014-10-27 19:48 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2014-10-27 19:48:21 PDT
Created attachment 240522 [details] the patch.
WebKit Commit Bot
Comment 2 2014-10-27 22:04:56 PDT
Comment on attachment 240522 [details] the patch. Clearing flags on attachment: 240522 Committed r175240: <http://trac.webkit.org/changeset/175240>
WebKit Commit Bot
Comment 3 2014-10-27 22:05:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.