Bug 138106 – AX: input type=hidden is being exposed when aria-hidden=false

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

If someone sticks a input type=hidden inside an aria-hidden=false region, then that will be exposed as a text field

<rdar://problem/18534039>

[chris fleizach]

Created attachment 240509 [details]
patch

[Benjamin Poulain]

Comment on attachment 240509 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240509&action=review

> LayoutTests/accessibility/input-type-hidden-in-aria-hidden-false.html:21
> +          var content = accessibilityController.accessibleElementById("content");
> +          shouldBe("content.childrenCount", "0");

For coverage I suggest the following:
1) Do not have aria-hidden="false" on #content, test childrenCount
2) Add aria-hidden, test childrenCount
3) Change to aria-hidden=true, test childrenCount
4) Change to aria-hidden=false, test childrenCount

That way all cases of [type=hidden] are covered.

> LayoutTests/accessibility/input-type-hidden-in-aria-hidden-false.html:23
> +          document.getElementById("content").style.visibility = "hidden";

Forgot this?

[chris fleizach]

(In reply to comment #2)
> Comment on attachment 240509 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240509&action=review
> 
> > LayoutTests/accessibility/input-type-hidden-in-aria-hidden-false.html:21
> > +          var content = accessibilityController.accessibleElementById("content");
> > +          shouldBe("content.childrenCount", "0");
> 
> For coverage I suggest the following:
> 1) Do not have aria-hidden="false" on #content, test childrenCount
> 2) Add aria-hidden, test childrenCount
> 3) Change to aria-hidden=true, test childrenCount
> 4) Change to aria-hidden=false, test childrenCount
> 
> That way all cases of [type=hidden] are covered.
> 
> > LayoutTests/accessibility/input-type-hidden-in-aria-hidden-false.html:23
> > +          document.getElementById("content").style.visibility = "hidden";
> 
> Forgot this?

Thanks! I'll make these changes

[chris fleizach]

http://trac.webkit.org/changeset/175241