Bug 138098 – http/tests/cookies/third-party-cookie-relaxing.html is flaky on bots

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Stephanie Lewis]

Failing intermittently on Yosemite WK1 Release bots.

https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK1%20(Tests)/r175220%20(186)/results.html
https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK1%20(Tests)/r175220%20(186)/http/tests/cookies/third-party-cookie-relaxing-pretty-diff.html

Updating expectations

[Alexey Proskuryakov]

As far as I can tell, updated expectations have not been landed yet.

This is kind of a bad test to skip, as we don't have much coverage. Looking into what's going on now.

I can reliably reproduce by running an arbitrary test repeatedly in one terminal window, and this test in another window:

run-webkit-tests -f --child-processes=7 --repeat=10000 css3/selectors3/html/css3-modsel-68.html

run-webkit-tests http/tests/cookies/third-party-cookie-relaxing.html --no-retry --no-show

[Stephanie Lewis]

Updated Expectations in http://trac.webkit.org/projects/webkit/changeset/175223

[Alexey Proskuryakov]

This is caused by this line in resetWebPreferencesToConsistentValues():

[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain];

This test temporarily sets a different cookie accept policy, which gets overridden when another DRT process executes this line, so we have a race.

Separate instances of DumpRenderTree are supposed to use separate cookie stores, so they should not be able to affect one another. The question is what changed in Yosemite that this is no longer true.

[Alexey Proskuryakov]

Looks like our parallel test processes used to always share cookie storages, but cookie accept policy wasn't read from the storage before Yosemite.

[Alexey Proskuryakov]

Created attachment 240506 [details]
proposed fix

[WebKit Commit Bot]

Comment on attachment 240506 [details]
proposed fix

Clearing flags on attachment: 240506

Committed r175232: <http://trac.webkit.org/changeset/175232>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

(In reply to comment #6)
> Comment on attachment 240506 [details]
> proposed fix
> 
> Clearing flags on attachment: 240506
> 
> Committed r175232: <http://trac.webkit.org/changeset/175232>

It broke the build on Apple Windows bots:

  1>..\platform\network\cf\NetworkStorageSessionCFNet.cpp(57): error C3861: 'getpid': identifier not found
     1>Done Building Project "C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj" (Build target(s)) -- FAILED.

Build FAILED.

[Alexey Proskuryakov]

Should be fixed in <http://trac.webkit.org/r175254>.