Bug 138086 - [GTK] Bump libsoup's minimum version to 2.42.0.
Summary: [GTK] Bump libsoup's minimum version to 2.42.0.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-26 14:03 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2014-12-08 09:00 PST (History)
9 users (show)

See Also:

Attachments
Patch (1.28 KB, patch)
2014-10-26 14:10 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
Patch (1.55 KB, patch)
2014-10-29 13:45 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2014-10-26 14:03:59 PDT 
[GTK] Bump libsoup's minimum version.
Comment 1 Martin Robinson 2014-10-26 14:05:58 PDT 
For GTK+, we shouldn't do this until the next major release. If you need to access a feature that's only accessible in a newer version of libsoup, I recommend simply using compile-time checks (https://developer.gnome.org/libsoup/stable/libsoup-2.4-Version-Information.html).
Comment 2 Raphael Kubo da Costa (:rakuco) 2014-10-26 14:10:11 PDT 
Created attachment 240469 [details]
Patch
Comment 3 Raphael Kubo da Costa (:rakuco) 2014-10-26 14:12:15 PDT 
Well it turns out both the 2.4 and 2.6 release series have used SOUP_CHECK_VERSION while stating in OptionsGTK.cmake that libsoup 2.40.3 was OK even though WebCore simply wouldn't build with that version.
Comment 4 Martin Robinson 2014-10-26 14:22:58 PDT 
Comment on attachment 240469 [details]
Patch

Judging by old mailing list threads it seems that WebKit2 has always depended upon 2.42, so I think the configuration file is simply incorrect here. We should probably just specify 2.42 here though.
Comment 5 Raphael Kubo da Costa (:rakuco) 2014-10-26 14:25:18 PDT 
Do you remember when those threads took place? Otherwise I'll try to look for those this week to add a proper explanation to the ChangeLog.
Comment 6 Martin Robinson 2014-10-26 15:17:12 PDT 
(In reply to comment #4)
> Comment on attachment 240469 [details]
> Patch
> 
> Judging by old mailing list threads it seems that WebKit2 has always
> depended upon 2.42, so I think the configuration file is simply incorrect
> here. We should probably just specify 2.42 here though.

Sure. Here is the relevant thread: https://lists.webkit.org/pipermail/webkit-gtk/2013-March/001387.html
Comment 7 Carlos Garcia Campos 2014-10-26 23:45:39 PDT 
I think this is simply yet another regression of the CMake switch, see:

http://trac.webkit.org/browser/releases/WebKitGTK/webkit-2.4/Source/autotools/Versions.m4#L33
Comment 8 Raphael Kubo da Costa (:rakuco) 2014-10-29 13:45:50 PDT 
Created attachment 240619 [details]
Patch
Comment 9 Raphael Kubo da Costa (:rakuco) 2014-10-29 14:04:24 PDT 
Comment on attachment 240619 [details]
Patch

Clearing flags on attachment: 240619

Committed r175344: <http://trac.webkit.org/changeset/175344>
Comment 10 Raphael Kubo da Costa (:rakuco) 2014-10-29 14:04:34 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 Raphael Kubo da Costa (:rakuco) 2014-10-29 14:05:08 PDT 
This might be useful in the 2.4 and 2.6 branches as well.
Comment 12 Alberto Garcia 2014-12-08 09:00:59 PST 
(In reply to comment #11)
> This might be useful in the 2.4 and 2.6 branches as well.

Both of them already depend on 2.42.0