RESOLVED FIXED 138086
[GTK] Bump libsoup's minimum version to 2.42.0. 
https://bugs.webkit.org/show_bug.cgi?id=138086
Summary [GTK] Bump libsoup's minimum version to 2.42.0.
Raphael Kubo da Costa (:rakuco)
Reported 2014-10-26 14:03:59 PDT
[GTK] Bump libsoup's minimum version.
Attachments
Patch (1.28 KB, patch)
2014-10-26 14:10 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Patch (1.55 KB, patch)
2014-10-29 13:45 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2014-10-26 14:05:58 PDT
For GTK+, we shouldn't do this until the next major release. If you need to access a feature that's only accessible in a newer version of libsoup, I recommend simply using compile-time checks (https://developer.gnome.org/libsoup/stable/libsoup-2.4-Version-Information.html).
Raphael Kubo da Costa (:rakuco)
Comment 2 2014-10-26 14:10:11 PDT
Created attachment 240469 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 3 2014-10-26 14:12:15 PDT
Well it turns out both the 2.4 and 2.6 release series have used SOUP_CHECK_VERSION while stating in OptionsGTK.cmake that libsoup 2.40.3 was OK even though WebCore simply wouldn't build with that version.
Martin Robinson
Comment 4 2014-10-26 14:22:58 PDT
Comment on attachment 240469 [details] Patch Judging by old mailing list threads it seems that WebKit2 has always depended upon 2.42, so I think the configuration file is simply incorrect here. We should probably just specify 2.42 here though.
Raphael Kubo da Costa (:rakuco)
Comment 5 2014-10-26 14:25:18 PDT
Do you remember when those threads took place? Otherwise I'll try to look for those this week to add a proper explanation to the ChangeLog.
Martin Robinson
Comment 6 2014-10-26 15:17:12 PDT
(In reply to comment #4) > Comment on attachment 240469 [details] > Patch > > Judging by old mailing list threads it seems that WebKit2 has always > depended upon 2.42, so I think the configuration file is simply incorrect > here. We should probably just specify 2.42 here though. Sure. Here is the relevant thread: https://lists.webkit.org/pipermail/webkit-gtk/2013-March/001387.html
Carlos Garcia Campos
Comment 7 2014-10-26 23:45:39 PDT
I think this is simply yet another regression of the CMake switch, see: http://trac.webkit.org/browser/releases/WebKitGTK/webkit-2.4/Source/autotools/Versions.m4#L33
Raphael Kubo da Costa (:rakuco)
Comment 8 2014-10-29 13:45:50 PDT
Created attachment 240619 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 9 2014-10-29 14:04:24 PDT
Comment on attachment 240619 [details] Patch Clearing flags on attachment: 240619 Committed r175344: <http://trac.webkit.org/changeset/175344>
Raphael Kubo da Costa (:rakuco)
Comment 10 2014-10-29 14:04:34 PDT
All reviewed patches have been landed. Closing bug.
Raphael Kubo da Costa (:rakuco)
Comment 11 2014-10-29 14:05:08 PDT
This might be useful in the 2.4 and 2.6 branches as well.
Alberto Garcia
Comment 12 2014-12-08 09:00:59 PST
(In reply to comment #11) > This might be useful in the 2.4 and 2.6 branches as well. Both of them already depend on 2.42.0
Note You need to log in before you can comment on or make changes to this bug.