Bug 138080 - Replace Element::didAffectSelector() by setNeedsStyleRecalc()
Summary: Replace Element::didAffectSelector() by setNeedsStyleRecalc()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-25 22:31 PDT by Benjamin Poulain
Modified: 2014-10-26 21:20 PDT (History)
0 users

See Also:

Attachments
Patch (9.51 KB, patch)
2014-10-25 22:35 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-10-25 22:31:54 PDT 
Replace Element::didAffectSelector() by setNeedsStyleRecalc()
Comment 1 Benjamin Poulain 2014-10-25 22:35:44 PDT 
Created attachment 240462 [details]
Patch
Comment 2 Andreas Kling 2014-10-26 12:52:10 PDT 
Comment on attachment 240462 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240462&action=review

r=me

> Source/WebCore/ChangeLog:9
> +        Element::didAffectSelector() was probably an optimization at some point,
> +        with the current code is does nothing more than setNeedsStyleRecalc().

A+ assessment, would believe again.
Comment 3 Benjamin Poulain 2014-10-26 21:20:19 PDT 
Comment on attachment 240462 [details]
Patch

Clearing flags on attachment: 240462

Committed r175212: <http://trac.webkit.org/changeset/175212>
Comment 4 Benjamin Poulain 2014-10-26 21:20:22 PDT 
All reviewed patches have been landed.  Closing bug.