WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
138080
Replace Element::didAffectSelector() by setNeedsStyleRecalc()
https://bugs.webkit.org/show_bug.cgi?id=138080
Summary
Replace Element::didAffectSelector() by setNeedsStyleRecalc()
Benjamin Poulain
Reported
2014-10-25 22:31:54 PDT
Replace Element::didAffectSelector() by setNeedsStyleRecalc()
Attachments
Patch
(9.51 KB, patch)
2014-10-25 22:35 PDT
,
Benjamin Poulain
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2014-10-25 22:35:44 PDT
Created
attachment 240462
[details]
Patch
Andreas Kling
Comment 2
2014-10-26 12:52:10 PDT
Comment on
attachment 240462
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=240462&action=review
r=me
> Source/WebCore/ChangeLog:9 > + Element::didAffectSelector() was probably an optimization at some point, > + with the current code is does nothing more than setNeedsStyleRecalc().
A+ assessment, would believe again.
Benjamin Poulain
Comment 3
2014-10-26 21:20:19 PDT
Comment on
attachment 240462
[details]
Patch Clearing flags on attachment: 240462 Committed
r175212
: <
http://trac.webkit.org/changeset/175212
>
Benjamin Poulain
Comment 4
2014-10-26 21:20:22 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug