Bug 138071 – Images with usemap should not have a link state

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Benjamin Poulain]

Images with usemap should not have a link state

[Benjamin Poulain]

Created attachment 240458 [details]
Patch

[Andreas Kling]

Comment on attachment 240458 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240458&action=review

r=me

> Source/WebCore/ChangeLog:11
> +        Unfortunatelly, the Accessibility code was relying on the wrong behavior

Unfortunately

> Source/WebCore/ChangeLog:27
> +        More with its setter for clarity.

Move

[Benjamin Poulain]

Committed r175213: <http://trac.webkit.org/changeset/175213>

[Darin Adler]

Comment on attachment 240458 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240458&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2458
> +    if (node && is<HTMLImageElement>(*node) && !downcast<HTMLImageElement>(*node).fastGetAttribute(usemapAttr).isNull())
> +        return ImageMapRole;

Writing !fastGetAttribute(x).isNull() is a more wordy roundabout way of writing fastHasAttribute(x); we should probably use fastHasAttribute instead.

[Benjamin Poulain]

(In reply to comment #4)
> Comment on attachment 240458 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240458&action=review
> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2458
> > +    if (node && is<HTMLImageElement>(*node) && !downcast<HTMLImageElement>(*node).fastGetAttribute(usemapAttr).isNull())
> > +        return ImageMapRole;
> 
> Writing !fastGetAttribute(x).isNull() is a more wordy roundabout way of
> writing fastHasAttribute(x); we should probably use fastHasAttribute instead.

Indeed, will fix.

[Alexey Proskuryakov]

Ben landed the cleanup in <https://trac.webkit.org/r175233>, which broke many tests. Hopefully fixed in <https://trac.webkit.org/r175237> (untested).

[Benjamin Poulain]

Arg, that was dumb :(

Thanks for fixing Alexey.