Bug 138063 - _actionMenuItemsForHitTestResult should also take a type indicating what the menu was built for
Summary: _actionMenuItemsForHitTestResult should also take a type indicating what the ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2014-10-24 16:25 PDT by Beth Dakin
Modified: 2014-10-24 16:52 PDT (History)
4 users (show)

See Also:

Patch (11.94 KB, patch)
2014-10-24 16:28 PDT, Beth Dakin
no flags Details | Formatted Diff | Diff
Patch v2 (11.94 KB, patch)
2014-10-24 16:40 PDT, Beth Dakin
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2014-10-24 16:25:07 PDT
_actionMenuItemsForHitTestResult should also take a type indicating what the menu was built for since HitTestResults that are both images and links could go either way.
Comment 1 Beth Dakin 2014-10-24 16:28:46 PDT
Created attachment 240445 [details]
Comment 2 Beth Dakin 2014-10-24 16:40:28 PDT
Created attachment 240446 [details]
Patch v2

Oopsie, that wasn't quite right. This one should do it.
Comment 3 mitz 2014-10-24 16:44:31 PDT
Comment on attachment 240446 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=240446&action=review

> Source/WebKit2/Shared/API/c/WKActionMenuTypes.h:40
> +typedef uint32_t WKActionMenuType;

Can you give this an underscore prefix in case we ever want to use this name for something in the modern API?

> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:68
> +

Extra newline.
Comment 4 Beth Dakin 2014-10-24 16:52:13 PDT
Thanks Dan! http://trac.webkit.org/changeset/175193