Bug 138059 - Very large images crash in action menu code
Summary: Very large images crash in action menu code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-24 15:18 PDT by Beth Dakin
Modified: 2014-10-24 16:05 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.54 KB, patch)
2014-10-24 15:21 PDT, Beth Dakin
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2014-10-24 15:18:20 PDT
Very large images crash in action menu code.

rdar://problem/18767859
Comment 1 Beth Dakin 2014-10-24 15:21:26 PDT
Created attachment 240440 [details]
Patch
Comment 2 Tim Horton 2014-10-24 15:24:26 PDT
Comment on attachment 240440 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240440&action=review

> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:186
> +    RefPtr<ShareableBitmap> bitmap = _hitTestResult.image;

could do this check in _defaultMenuItems instead so we can do smart fallback there and not worry about these things here.
Comment 3 Beth Dakin 2014-10-24 15:28:17 PDT
http://trac.webkit.org/changeset/175187