Use modern loops in ResourceRequestCocoa.mm and leverage Objective-C's fast enumeration.
Created attachment 240424 [details] Patch
Attachment 240424 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm:88: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 240424 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240424&action=review > Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm:88 > + [[m_nsRequest.get() allHTTPHeaderFields] enumerateKeysAndObjectsUsingBlock: ^(NSString *name, NSString *value, BOOL *) { You don’t need the .get() here. > Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm:95 > + for (NSNumber *encodingFallback in [m_nsRequest.get() contentDispositionEncodingFallbackArray]) { You don’t need the .get() here. > Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm:172 > + RetainPtr<CFStringRef> cfEncodingName = encodingName.createCFString(); > + CFStringEncoding nsEncoding = CFStringConvertEncodingToNSStringEncoding(CFStringConvertIANACharSetNameToEncoding(cfEncodingName.get())); Reads fine without the local variable. Just encodingName.createCFString().get().
Created attachment 240436 [details] Patch
Attachment 240436 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm:88: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 240436 [details] Patch Clearing flags on attachment: 240436 Committed r175186: <http://trac.webkit.org/changeset/175186>
All reviewed patches have been landed. Closing bug.