RESOLVED FIXED 138051
Simplified IndexingType's hasAnyArrayStorage() 
https://bugs.webkit.org/show_bug.cgi?id=138051
Summary Simplified IndexingType's hasAnyArrayStorage()
Mark Lam
Reported 2014-10-24 11:51:42 PDT
IndexingType's hasAnyArrayStorage() currently does subtraction of ArrayStorageShape with the purpose of making non-ArrayStorage types underflow (with that subtraction) and have a result that exceeds SlowPutArrayStorageShape. What it is doing is basically checking for a shape value that is greater equal to ArrayStorageShape. We can just simplify the code as such.
Attachments
the patch. (2.73 KB, patch)
2014-10-24 11:57 PDT, Mark Lam 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2014-10-24 11:57:11 PDT
Created attachment 240421 [details] the patch.
Michael Saboff
Comment 2 2014-10-24 12:10:38 PDT
Comment on attachment 240421 [details] the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=240421&action=review r=me Fix the comment issues. > Source/JavaScriptCore/runtime/IndexingType.h:39 > + struct IndextingType { Spelling of IndextingType > Source/JavaScriptCore/runtime/IndexingType.h:42 > + uint8_t maHaveIndexedShapes:1; // bit 5 Should this be mayHaveIndexedShapes?
Mark Lam
Comment 3 2014-10-24 12:18:11 PDT
Thanks. I also found 2 more errors in the comments (should not have tabs, and "mayHaveIndexedAccessors"instead of "mayHaveIndexedShape"). Fixed comments, and landed in r175172: <http://trac.webkit.org/r175172>.
Note You need to log in before you can comment on or make changes to this bug.