Avoid unnecessary NSURLRequest copies in ResourceRequest::doUpdatePlatformRequest() / doUpdatePlatformHTTPBody(). It turns out that half the time, m_nsRequest is already mutable so it is unnecessary to call [NSURLRequest mutableCopy], we can just cast to an NSMutableURLRequest* and avoid copying.
Created attachment 240418 [details]
Comment on attachment 240418 [details]
Clearing flags on attachment: 240418
Committed r175171: <http://trac.webkit.org/changeset/175171>
All reviewed patches have been landed. Closing bug.
This got rolled out. Do we know what the problem was? Was it that the mutable NSURLRequest wasn't expected to be changed?
(In reply to comment #4)
> This got rolled out. Do we know what the problem was? Was it that the
> mutable NSURLRequest wasn't expected to be changed?
I haven't had time to investigate yet. My priority was to safely and quickly fix the crash at this point and a simple roll out seemed like the right thing to do.
I'll take another look when I get some spare cycles.
Reopening since it was rolled out.