Bug 138044 - Add optimized fullscreen mode.
Summary: Add optimized fullscreen mode.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords:
Depends on: 138320
Blocks:
  Show dependency tree / graph
 
Reported: 2014-10-24 04:37 PDT by Jeremy Jones
Modified: 2014-11-03 12:45 PST (History)
7 users (show)

See Also:

Attachments
Patch (41.57 KB, patch)
2014-10-27 12:26 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Patch (41.62 KB, patch)
2014-10-27 17:49 PDT, Jeremy Jones 		jer.noble: review+
Details | Formatted Diff | Diff
Patch for landing. (41.42 KB, patch)
2014-10-28 13:07 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2014-10-24 04:37:06 PDT 
Add optimized fullscreen mode.
Comment 1 Simon Fraser (smfr) 2014-10-24 11:07:21 PDT 
What does "optimized fullscreen" mean?
Comment 2 Jeremy Jones 2014-10-27 12:06:13 PDT 
rdar://problem/18762317
Comment 3 Jeremy Jones 2014-10-27 12:26:02 PDT 
Created attachment 240492 [details]
Patch
Comment 4 WebKit Commit Bot 2014-10-27 12:28:43 PDT 
Attachment 240492 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:873:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:956:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Jeremy Jones 2014-10-27 17:49:06 PDT 
Created attachment 240516 [details]
Patch
Comment 6 WebKit Commit Bot 2014-10-27 17:50:42 PDT 
Attachment 240516 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:873:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:888:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:955:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Jer Noble 2014-10-28 10:45:34 PDT 
Comment on attachment 240516 [details]
Patch

r=me, but this still needs to be signed off by a WK2 reviewer.
Comment 8 Anders Carlsson 2014-10-28 10:49:19 PDT 
WK2 parts look fine.
Comment 9 Jeremy Jones 2014-10-28 13:07:23 PDT 
Created attachment 240565 [details]
Patch for landing.
Comment 10 WebKit Commit Bot 2014-10-28 13:09:01 PDT 
Attachment 240565 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:868:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:883:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:950:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 WebKit Commit Bot 2014-10-28 16:14:40 PDT 
Comment on attachment 240565 [details]
Patch for landing.

Clearing flags on attachment: 240565

Committed r175279: <http://trac.webkit.org/changeset/175279>