RESOLVED FIXED 138031
[iOS WK2] If a page has the exact same VisibleContentRect as the page before, its VisibleContentRectUpdate can be ignored 
https://bugs.webkit.org/show_bug.cgi?id=138031
Summary [iOS WK2] If a page has the exact same VisibleContentRect as the page before,...
Benjamin Poulain
Reported 2014-10-23 17:06:25 PDT
[iOS WK2] If a page has the exact same VisibleContentRect as the page before, its VisibleContentRectUpdate can be ignored
Attachments
Patch (6.33 KB, patch)
2014-10-23 17:19 PDT, Benjamin Poulain 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-10-23 17:19:34 PDT
Created attachment 240379 [details] Patch
Simon Fraser (smfr)
Comment 2 2014-10-23 17:31:53 PDT
Comment on attachment 240379 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240379&action=review Mumble testing mumble. > Source/WebKit2/UIProcess/WebPageProxy.cpp:2624 > + m_firstLayerTreeTransactionIdAfterDidCommitLoadForMainFrame = downcast<RemoteLayerTreeDrawingAreaProxy>(*drawingArea()).nextLayerTreeTransactionID(); It makes me slightly uneasy just fetching nextLayerTreeTransactionID(). How about changing it to m_layerTreeTransactionIdAtDidCommitLoad and just using the ID of the last received transaction? Then lower down you would have: layerTreeTransaction.transactionID() > m_layerTreeTransactionIdAtDidCommitLoad > Source/WebKit2/UIProcess/WebPageProxy.h:1361 > + bool m_hasReceivedLayerTreeTransactionAfterDidCommitLoadForMainFrame; > + uint64_t m_firstLayerTreeTransactionIdAfterDidCommitLoadForMainFrame; These names are really long. I think you could drop the "ForMainFrame".
Benjamin Poulain
Comment 3 2014-10-23 17:44:03 PDT
Committed r175153: <http://trac.webkit.org/changeset/175153>
Note You need to log in before you can comment on or make changes to this bug.