Bug 138030 - [Mac] Optimize URL::createCFURL() for the common case
Summary: [Mac] Optimize URL::createCFURL() for the common case
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac Unspecified
: P2 Enhancement
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-23 16:32 PDT by Chris Dumez
Modified: 2014-10-23 18:29 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.86 KB, patch)
2014-10-23 16:39 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-10-23 16:32:47 PDT 
Optimize URL::createCFURL() for the common case by adding a fast path for when the URL String is already 8-bit (common case).
When the string is 8-bit, we don't need to copy the bytes in a temporary buffer and we can construct the CFURLRef directly from it.
This makes URL::createCFURL() ~34% faster on my machine.
Comment 1 Chris Dumez 2014-10-23 16:39:48 PDT 
Created attachment 240376 [details]
Patch
Comment 2 WebKit Commit Bot 2014-10-23 18:29:49 PDT 
Comment on attachment 240376 [details]
Patch

Clearing flags on attachment: 240376

Committed r175154: <http://trac.webkit.org/changeset/175154>
Comment 3 WebKit Commit Bot 2014-10-23 18:29:54 PDT 
All reviewed patches have been landed.  Closing bug.