Bug 138027 - Add some SPI headers for NSExtension and NSSharingService{Picker}
Summary: Add some SPI headers for NSExtension and NSSharingService{Picker}
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-10-23 15:39 PDT by Tim Horton
Modified: 2014-10-23 16:02 PDT (History)
9 users (show)

See Also:

Attachments
Patch (25.96 KB, patch)
2014-10-23 15:40 PDT, Tim Horton 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-10-23 15:39:48 PDT 
Add some SPI headers for NSExtension and NSSharingService{Picker}
Comment 1 Tim Horton 2014-10-23 15:40:25 PDT 
Created attachment 240372 [details]
Patch
Comment 2 WebKit Commit Bot 2014-10-23 15:43:11 PDT 
Attachment 240372 [details] did not pass style-queue:


ERROR: Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
ERROR: Source/WebCore/platform/spi/mac/NSSharingServiceSPI.h:40:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/Misc/WebSharingServicePickerController.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit/mac/ChangeLog:3:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
ERROR: Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 5 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2014-10-23 16:01:14 PDT 
https://trac.webkit.org/changeset/175147
Comment 4 Radar WebKit Bug Importer 2014-10-23 16:02:23 PDT 
<rdar://problem/18757166>