Bug 138019 - Clean up virtual functions in dom/
Summary: Clean up virtual functions in dom/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-23 13:51 PDT by Chris Dumez
Modified: 2014-10-23 16:26 PDT (History)
8 users (show)

See Also:

Attachments
Patch (37.50 KB, patch)
2014-10-23 13:55 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (38.63 KB, patch)
2014-10-23 15:06 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-10-23 13:51:46 PDT 
Clean up virtual functions in rendering/ by:
    - Making virtual functions final when possible
    - Making classes final when possible
    - Using 'override' when appropriate
    - Explicitly marking functions / destructors as virtual when they are
      inherently virtual
    - Making isXXX() virtual functions private on XXX classes to avoid
      unnecessary type checks
    - Dropping final for virtual functions in classes already marked as
      final
Comment 1 Chris Dumez 2014-10-23 13:55:00 PDT 
Created attachment 240366 [details]
Patch
Comment 2 WebKit Commit Bot 2014-10-23 13:56:33 PDT 
Attachment 240366 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/MutationEvent.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2014-10-23 15:06:10 PDT 
Created attachment 240371 [details]
Patch
Comment 4 WebKit Commit Bot 2014-10-23 15:07:23 PDT 
Attachment 240371 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/MutationEvent.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 WebKit Commit Bot 2014-10-23 16:25:59 PDT 
Comment on attachment 240371 [details]
Patch

Clearing flags on attachment: 240371

Committed r175148: <http://trac.webkit.org/changeset/175148>
Comment 6 WebKit Commit Bot 2014-10-23 16:26:05 PDT 
All reviewed patches have been landed.  Closing bug.