Bug 138019 – Clean up virtual functions in dom/

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Clean up virtual functions in rendering/ by:
    - Making virtual functions final when possible
    - Making classes final when possible
    - Using 'override' when appropriate
    - Explicitly marking functions / destructors as virtual when they are
      inherently virtual
    - Making isXXX() virtual functions private on XXX classes to avoid
      unnecessary type checks
    - Dropping final for virtual functions in classes already marked as
      final

[Chris Dumez]

Created attachment 240366 [details]
Patch

[WebKit Commit Bot]

Attachment 240366 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/MutationEvent.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 240371 [details]
Patch

[WebKit Commit Bot]

Attachment 240371 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/MutationEvent.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 240371 [details]
Patch

Clearing flags on attachment: 240371

Committed r175148: <http://trac.webkit.org/changeset/175148>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.