Bug 137997 - Refactoring to simplify some code in DatePrototype.cpp
Summary: Refactoring to simplify some code in DatePrototype.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-22 18:51 PDT by Mark Lam
Modified: 2014-10-22 19:39 PDT (History)
1 user (show)

See Also:

Attachments
the patch. (5.43 KB, patch)
2014-10-22 18:56 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-10-22 18:51:53 PDT 
A bunch of functions in DatePrototype.cpp have the pattern of loading a constant into a local variable only to pass it to a callee function immediately after.  There is no other use for that variable.  This adds additional verbosity with no added benefit.  Will fix.
Comment 1 Mark Lam 2014-10-22 18:56:18 PDT 
Created attachment 240319 [details]
the patch.
Comment 2 Filip Pizlo 2014-10-22 19:01:16 PDT 
Comment on attachment 240319 [details]
the patch.

Nice!
Comment 3 WebKit Commit Bot 2014-10-22 19:39:13 PDT 
Comment on attachment 240319 [details]
the patch.

Clearing flags on attachment: 240319

Committed r175080: <http://trac.webkit.org/changeset/175080>
Comment 4 WebKit Commit Bot 2014-10-22 19:39:15 PDT 
All reviewed patches have been landed.  Closing bug.