Bug 137985 - commitqueuetask_unittest.py should be made more concise.
Summary: commitqueuetask_unittest.py should be made more concise.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-22 15:57 PDT by Jake Nielsen
Modified: 2014-10-22 19:54 PDT (History)
3 users (show)

See Also:

Attachments
Almost 1:3 addition to deletion ratio! Alright! (29.04 KB, patch)
2014-10-22 17:11 PDT, Jake Nielsen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jake Nielsen 2014-10-22 15:57:15 PDT 
There are several tests that could use MockSimpleTestPlanCommitQueue to test patch-testing behavior, but instead use MockCommitQueue and pass/fail based on the log messages that it generates.
If they were moved over, the tests would become more readable, more concise, and less brittle.
Comment 1 Jake Nielsen 2014-10-22 17:11:30 PDT 
Created attachment 240308 [details]
Almost 1:3 addition to deletion ratio! Alright!
Comment 2 WebKit Commit Bot 2014-10-22 19:54:27 PDT 
Comment on attachment 240308 [details]
Almost 1:3 addition to deletion ratio! Alright!

Clearing flags on attachment: 240308

Committed r175082: <http://trac.webkit.org/changeset/175082>
Comment 3 WebKit Commit Bot 2014-10-22 19:54:31 PDT 
All reviewed patches have been landed.  Closing bug.