RESOLVED FIXED 137985
commitqueuetask_unittest.py should be made more concise. 
https://bugs.webkit.org/show_bug.cgi?id=137985
Summary commitqueuetask_unittest.py should be made more concise.
Jake Nielsen
Reported 2014-10-22 15:57:15 PDT
There are several tests that could use MockSimpleTestPlanCommitQueue to test patch-testing behavior, but instead use MockCommitQueue and pass/fail based on the log messages that it generates. If they were moved over, the tests would become more readable, more concise, and less brittle.
Attachments
Almost 1:3 addition to deletion ratio! Alright! (29.04 KB, patch)
2014-10-22 17:11 PDT, Jake Nielsen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jake Nielsen
Comment 1 2014-10-22 17:11:30 PDT
Created attachment 240308 [details] Almost 1:3 addition to deletion ratio! Alright!
WebKit Commit Bot
Comment 2 2014-10-22 19:54:27 PDT
Comment on attachment 240308 [details] Almost 1:3 addition to deletion ratio! Alright! Clearing flags on attachment: 240308 Committed r175082: <http://trac.webkit.org/changeset/175082>
WebKit Commit Bot
Comment 3 2014-10-22 19:54:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.