Bug 137983 - [Mac] don't update caption user style sheet during parsing
Summary: [Mac] don't update caption user style sheet during parsing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-22 15:07 PDT by Eric Carlson
Modified: 2014-10-23 13:27 PDT (History)
5 users (show)

See Also:

Attachments
Proposed patch. (1.85 KB, patch)
2014-10-23 10:53 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Updated patch (3.74 KB, patch)
2014-10-23 11:32 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2014-10-22 15:07:30 PDT 
CaptionUserPreferencesMediaAF::setInterestedInCaptionPreferenceChanges is called whenever a audio or video element is created. It calls updateCaptionStyleSheetOveride which generates and inserts a user style sheet. This is an expensive operation and it can happen during document parsing/creation, so it should be done after a brief delay.
Comment 1 Eric Carlson 2014-10-23 10:53:52 PDT 
Created attachment 240351 [details]
Proposed patch.
Comment 2 Eric Carlson 2014-10-23 11:32:23 PDT 
Created attachment 240355 [details]
Updated patch
Comment 3 WebKit Commit Bot 2014-10-23 13:27:25 PDT 
Comment on attachment 240355 [details]
Updated patch

Clearing flags on attachment: 240355

Committed r175139: <http://trac.webkit.org/changeset/175139>
Comment 4 WebKit Commit Bot 2014-10-23 13:27:29 PDT 
All reviewed patches have been landed.  Closing bug.