RESOLVED FIXED 137977
commitqueuetask should include more tests to ensure that the behavior of PatchAnalysisTask._test_patch() is well defined 
https://bugs.webkit.org/show_bug.cgi?id=137977
Summary commitqueuetask should include more tests to ensure that the behavior of Patc...
Jake Nielsen
Reported 2014-10-22 12:20:37 PDT
This may also include adding some more convenient mocking/testing infrastructure to make it easier to write new tests.
Attachments
Just for viewing purposes (7.47 KB, patch)
2014-10-22 14:42 PDT, Jake Nielsen 		jake.nielsen.webkit: review-
jake.nielsen.webkit: commit-queue-
DetailsFormatted DiffDiff
Adds FIXMEs to tests, and sets the test expectations to agree with current behavior. (11.75 KB, patch)
2014-10-22 15:44 PDT, Jake Nielsen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jake Nielsen
Comment 1 2014-10-22 14:42:10 PDT
Created attachment 240297 [details] Just for viewing purposes I just want to discuss some of the added test cases.
Jake Nielsen
Comment 2 2014-10-22 15:44:18 PDT
Created attachment 240300 [details] Adds FIXMEs to tests, and sets the test expectations to agree with current behavior.
WebKit Commit Bot
Comment 3 2014-10-22 16:27:26 PDT
Comment on attachment 240300 [details] Adds FIXMEs to tests, and sets the test expectations to agree with current behavior. Clearing flags on attachment: 240300 Committed r175073: <http://trac.webkit.org/changeset/175073>
WebKit Commit Bot
Comment 4 2014-10-22 16:27:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.