Bug 137977 - commitqueuetask should include more tests to ensure that the behavior of PatchAnalysisTask._test_patch() is well defined
Summary: commitqueuetask should include more tests to ensure that the behavior of Patc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jake Nielsen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-22 12:20 PDT by Jake Nielsen
Modified: 2014-10-22 16:27 PDT (History)
3 users (show)

See Also:

Attachments
Just for viewing purposes (7.47 KB, patch)
2014-10-22 14:42 PDT, Jake Nielsen 		jake.nielsen.webkit: review-
jake.nielsen.webkit: commit-queue-
Details | Formatted Diff | Diff
Adds FIXMEs to tests, and sets the test expectations to agree with current behavior. (11.75 KB, patch)
2014-10-22 15:44 PDT, Jake Nielsen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jake Nielsen 2014-10-22 12:20:37 PDT 
This may also include adding some more convenient mocking/testing infrastructure to make it easier to write new tests.
Comment 1 Jake Nielsen 2014-10-22 14:42:10 PDT 
Created attachment 240297 [details]
Just for viewing purposes

I just want to discuss some of the added test cases.
Comment 2 Jake Nielsen 2014-10-22 15:44:18 PDT 
Created attachment 240300 [details]
Adds FIXMEs to tests, and sets the test expectations to agree with current behavior.
Comment 3 WebKit Commit Bot 2014-10-22 16:27:26 PDT 
Comment on attachment 240300 [details]
Adds FIXMEs to tests, and sets the test expectations to agree with current behavior.

Clearing flags on attachment: 240300

Committed r175073: <http://trac.webkit.org/changeset/175073>
Comment 4 WebKit Commit Bot 2014-10-22 16:27:30 PDT 
All reviewed patches have been landed.  Closing bug.