Bug 137957 - [TexMap] Clean up virtual method declarations in GraphicsLayerTextureMapper
Summary: [TexMap] Clean up virtual method declarations in GraphicsLayerTextureMapper
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-22 06:51 PDT by Zan Dobersek
Modified: 2014-10-23 04:17 PDT (History)
7 users (show)

See Also:

Attachments
Patch (10.25 KB, patch)
2014-10-22 06:58 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-10-22 06:51:37 PDT 
[TexMap] Clean up virtual method declarations in GraphicsLayerTextureMapper
Comment 1 Zan Dobersek 2014-10-22 06:58:17 PDT 
Created attachment 240271 [details]
Patch
Comment 2 Martin Robinson 2014-10-22 07:51:03 PDT 
Comment on attachment 240271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240271&action=review

> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h:35
> +class GraphicsLayerTextureMapper final : public GraphicsLayer, TextureMapperPlatformLayer::Client {

Why is TextureMapperPlatformLayer::Client no longer public here?
Comment 3 Zan Dobersek 2014-10-22 08:41:43 PDT 
Comment on attachment 240271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240271&action=review

>> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h:35
>> +class GraphicsLayerTextureMapper final : public GraphicsLayer, TextureMapperPlatformLayer::Client {
> 
> Why is TextureMapperPlatformLayer::Client no longer public here?

There's no need for that -- there are no member variables that we would need access to (or at all) in that class, and the overriding methods in GraphicsLayerTextureMapper are also private.
Comment 4 Martin Robinson 2014-10-22 08:44:03 PDT 
(In reply to comment #3)
> Comment on attachment 240271 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240271&action=review
> 
> >> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h:35
> >> +class GraphicsLayerTextureMapper final : public GraphicsLayer, TextureMapperPlatformLayer::Client {
> > 
> > Why is TextureMapperPlatformLayer::Client no longer public here?
> 
> There's no need for that -- there are no member variables that we would need
> access to (or at all) in that class, and the overriding methods in
> GraphicsLayerTextureMapper are also private.

Is it common in WebKit to use private inheritance?
Comment 5 Zan Dobersek 2014-10-22 09:03:40 PDT 
Comment on attachment 240271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240271&action=review

>>>> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h:35
>>>> +class GraphicsLayerTextureMapper final : public GraphicsLayer, TextureMapperPlatformLayer::Client {
>>> 
>>> Why is TextureMapperPlatformLayer::Client no longer public here?
>> 
>> There's no need for that -- there are no member variables that we would need access to (or at all) in that class, and the overriding methods in GraphicsLayerTextureMapper are also private.
> 
> Is it common in WebKit to use private inheritance?

I count 8 cases in WebCore, 14 in WebKit2. Not the most common pattern, but not shunned either.
Comment 6 Zan Dobersek 2014-10-23 04:17:36 PDT 
Comment on attachment 240271 [details]
Patch

Clearing flags on attachment: 240271

Committed r175116: <http://trac.webkit.org/changeset/175116>
Comment 7 Zan Dobersek 2014-10-23 04:17:45 PDT 
All reviewed patches have been landed.  Closing bug.